Adopted the new settings dialog component for obo nodes#1944
Conversation
jpeterson976
left a comment
There was a problem hiding this comment.
The only thing that I noticed is that the width and height input boxes for custom sized figures are no longer centered vertically with the new dialog, but everything else looks to be the same as the old versions.
|
Good catch! Fixing that now. |
deundrewilliams
left a comment
There was a problem hiding this comment.
All updated dialogs are centered, lgtm
…dialogs as close as possible to that of the old dialogs.
6682126
|
@maufcost Double-check that the two minor changes I made to the CSS didn't bug up anything you've done, otherwise this looks like it's ready to go. |
|
Checking that now, and I will get back to you in a couple minutes :) |
|
Just checked all the updated modals. As far as my testing goes, they are good to go! |
deundrewilliams
left a comment
There was a problem hiding this comment.
Dialogs are still centered after CSS updates, lgtm
jpeterson976
left a comment
There was a problem hiding this comment.
Stuff still works, LGTM!
The base branch was changed.




Node dialogs that were not updated:
Node dialogs that were updated:
As always, let me know if you would like me to make any changes.
Fixes #1775