Ban typing.TypeVar in favor of typing_extensions.TypeVar#3350
Merged
Conversation
sobolevn
approved these changes
May 2, 2026
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
Technically, this is only needed for default= argument, but we can use it for all cases with no problems.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made things!
We declare a dependency on typing_extensions so this ensure
default=...works with all supported python.I've added a banned-api ruff rule to ensure if cannot regress
Related issues
Had issue in ci for #3317 which made me think of this
AI Policy