-
-
Notifications
You must be signed in to change notification settings - Fork 561
feat: implement manual type-checking for Meta attributes to fix #2823 #3295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
01xnikhil
wants to merge
25
commits into
typeddjango:master
Choose a base branch
from
01xnikhil:feat-meta-validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+102
−78
Open
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dc76c80
feat: add type validation for nested Meta class attributes
01xnikhil 14f7bd3
Fix: resolve internal errors and strict typing issues in Meta validation
01xnikhil 3e973dc
Revert main.py and remove reproduction script as requested
01xnikhil 3ea6398
feat: add type validation for nested Meta class
01xnikhil 8052104
feat: implement type validation for Meta class with clean formatting
01xnikhil 83a94f5
fix: resolve truthy-bool CI failures and improve Meta validation safety
01xnikhil 388ec03
fix: address truthy-bool errors with strict getattr and is not None c…
01xnikhil 52fa129
fix: explicit node checks and ruff formatting for Meta validation
01xnikhil c9ecef9
fix: explicit node checks and resolved ruff formatting
01xnikhil 3e77c0f
prepare for rebase and restrict validation to TypedModelMeta
01xnikhil 5689b50
fix: resolve regressions and implement manual type-checking
01xnikhil cf276ca
fix: restrict Meta validation to TypedModelMeta to fix stubtest
01xnikhil dcb6943
fix: resolve stubtest failures and unreachable code in models.py
01xnikhil edcfe23
fix: comprehensive fix for stubtest, matrix, and self-check failures
01xnikhil 2246eba
fix: integrate TypedModelMeta validation with standard plugin flow
01xnikhil c7d624f
fix: integrate
01xnikhil 99c25d0
fix: integrates
01xnikhil 56cfbad
fix: my 14 commit
01xnikhil a3af23c
fix: my 15 commit
01xnikhil 72faca1
fix: my 16 commit
01xnikhil b3875eb
fix: my 17 commit
01xnikhil c68b5a4
fix: my 18 commit
01xnikhil 6de9324
fix: my 19 commit
01xnikhil 58dc51f
fix: my 20 commit
01xnikhil 43fc35a
fix: my 21 commit
01xnikhil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to this file need to be reverted I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! I understand. I have reverted the changes in main.py to keep the PR focused solely on the Meta validation logic in models.py. I have also ensured that models.py follows the manual type-checking approach as discussed in issue #2823.