Skip to content

chore: Increase mem and CPU limits for providers#674

Open
ruivieira wants to merge 1 commit intotrustyai-explainability:mainfrom
ruivieira:collection-limits
Open

chore: Increase mem and CPU limits for providers#674
ruivieira wants to merge 1 commit intotrustyai-explainability:mainfrom
ruivieira:collection-limits

Conversation

@ruivieira
Copy link
Copy Markdown
Member

@ruivieira ruivieira commented Mar 13, 2026

Summary by CodeRabbit

  • Chores
    • Improved resource allocations for evaluation services to enhance performance and stability. Increased CPU and memory resources across multiple evaluation providers to better handle concurrent workloads and prevent resource constraints.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4627fe60-4be1-4e50-a0a7-d2909454ebdb

📥 Commits

Reviewing files that changed from the base of the PR and between 4785855 and f1890b4.

📒 Files selected for processing (4)
  • config/configmaps/evalhub/provider-garak.yaml
  • config/configmaps/evalhub/provider-guidellm.yaml
  • config/configmaps/evalhub/provider-lighteval.yaml
  • config/configmaps/evalhub/provider-lm-evaluation-harness.yaml

📝 Walkthrough

Walkthrough

Four Kubernetes configuration files for EvalHub providers have their runtime resource requests and limits increased. CPU and memory allocations are scaled up uniformly across garak, guidellm, lighteval, and lm-evaluation-harness providers with no functional logic changes.

Changes

Cohort / File(s) Summary
Moderate resource scaling
config/configmaps/evalhub/provider-garak.yaml, config/configmaps/evalhub/provider-guidellm.yaml
CPU request increased to 250m, memory request to 512Mi; CPU limit to 2000m, memory limit to 4Gi.
Aggressive resource scaling
config/configmaps/evalhub/provider-lighteval.yaml, config/configmaps/evalhub/provider-lm-evaluation-harness.yaml
CPU request increased to 500m, memory request to 1Gi; CPU limit to 4000m, memory limit to 8Gi.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Whiskers twitching with delight,
Resources scaled to new heights!
More memory, more CPU to chew,
Our providers now have room to grew. 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Increase mem and CPU limits for providers' directly and accurately describes the main change across all four modified files, which involve increasing Kubernetes resource requests and limits.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@saichandrapandraju
Copy link
Copy Markdown
Contributor

Hi @ruivieira , shall we do the same for 'provider-garak-kfp.yaml' as well?

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 13, 2026

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e f1890b4 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Copy Markdown

@mariusdanciu mariusdanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mariusdanciu, ppadashe-psp, RobGeada, saichandrapandraju, tarilabs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 6, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants