feat(evalhub): add RAGAS provider configuration and update images#664
feat(evalhub): add RAGAS provider configuration and update images#664ruivieira wants to merge 2 commits intotrustyai-explainability:mainfrom
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds a RagAS EvalHub provider ConfigMap and image variables, updates provider image references, grants namespace list/watch RBAC, and implements tenant-namespace reconciliation (create/cleanup of tenant-scoped SAs, RoleBindings, and service-CA ConfigMaps) plus related controller wiring and tests. Changes
Sequence Diagram(s)sequenceDiagram
participant Namespace
participant EvalHubController as EvalHub Controller
participant K8sAPI as Kubernetes API
participant ClusterRole
participant ConfigMap
Namespace->>EvalHubController: Namespace event (labelled tenant)
EvalHubController->>EvalHubController: mapNamespaceToEvalHubs -> enqueue EvalHub reconcile
EvalHubController->>K8sAPI: List EvalHub instances
EvalHubController->>K8sAPI: create ServiceAccount (tenant ns)
EvalHubController->>K8sAPI: create RoleBinding -> ClusterRole (cross-namespace subjectNamespace)
EvalHubController->>K8sAPI: ensure service-CA ConfigMap with CA inject annotation
EvalHubController->>ConfigMap: read operator image ConfigMap (get image)
K8sAPI-->>EvalHubController: resource status / errors
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -21,4 +21,5 @@ nemo-guardrails-image=quay.io/trustyai/nemo-guardrails-server:latest | |||
| evalhub-provider-garak-image=quay.io/evalhub/garak:latest | |||
There was a problem hiding this comment.
can we for now give quay.io/trustyai/trustyai-garak-lls-provider-dsp:latest for this?
| @@ -21,4 +21,5 @@ nemo-guardrails-image=quay.io/trustyai/nemo-guardrails-server:latest | |||
| evalhub-provider-garak-image=quay.io/evalhub/garak:latest | |||
There was a problem hiding this comment.
can we for now give quay.io/trustyai/trustyai-garak-lls-provider-dsp:latest for this?
- Introduced a new ConfigMap for the RAGAS provider, defining its metrics and benchmarks. - Updated kustomization files to include the new RAGAS provider resources. - Modified image references in params.env files for consistency across environments.
821e69c to
7ba2b3f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saichandrapandraju The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary by CodeRabbit
New Features
Chores
Other