Skip to content

feat(RHOAIENG-33054): increase timeout of the orchestrator route#542

Open
m-misiura wants to merge 1 commit intotrustyai-explainability:mainfrom
m-misiura:rhoaieng-33054
Open

feat(RHOAIENG-33054): increase timeout of the orchestrator route#542
m-misiura wants to merge 1 commit intotrustyai-explainability:mainfrom
m-misiura:rhoaieng-33054

Conversation

@m-misiura
Copy link
Copy Markdown
Contributor

@m-misiura m-misiura commented Aug 28, 2025

Please refer to RHOAIENG-33054 for a description of an issue

I have added timeout annotation (5m) in controllers/gorch/templates/https-route.tmpl.yaml

Let me know if you think this fix would work

Summary by Sourcery

New Features:

  • Add haproxy.router.openshift.io/timeout annotation set to 5m on the orchestrator route template

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Aug 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR raises the HAProxy router timeout for orchestrator routes by introducing a new 5-minute timeout annotation in the route template.

File-Level Changes

Change Details Files
Added a 5-minute HAProxy timeout annotation to the HTTPS route template
  • Inserted an 'annotations' block under metadata
  • Configured 'haproxy.router.openshift.io/timeout' with value '5m'
controllers/gorch/templates/https-route.tmpl.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@m-misiura m-misiura added the kind/bug Something isn't working label Aug 28, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 28, 2025

@m-misiura: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 8e9c988 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: christinaexyou

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:8e9c988201bed51f7c427c20b83146fa4b4fa9fa

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver-ci:8e9c988201bed51f7c427c20b83146fa4b4fa9fa

📦 LMES job image: quay.io/trustyai/ta-lmes-job-ci:8e9c988201bed51f7c427c20b83146fa4b4fa9fa

📦 Guardrails orchestrator image: quay.io/trustyai/ta-guardrails-orchestrator-ci:8e9c988201bed51f7c427c20b83146fa4b4fa9fa

🗂️ CI manifests

      devFlags:
        manifests:
          - contextDir: config
            sourcePath: ''
            uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-8e9c988201bed51f7c427c20b83146fa4b4fa9fa

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 18, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working lgtm needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants