fix params#1687
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e71dbc. Configure here.
architkumar-truefoundry
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Provider metadata-only changes with no runtime code; misconfiguration could affect how max output tokens are passed to Azure for these four models.
Overview
Updates four Azure Open AI gpt-5-chat model definitions so output length is configured via
max_completion_tokensinstead ofmax_tokens, matching newer Azure/OpenAI chat APIs and the pattern already used on models like gpt-4.1-mini.Each touched YAML swaps the
paramskey frommax_tokenstomax_completion_tokens(defaults and max/min bounds unchanged where they existed).removeParamsnow listsmax_tokensso upstream clients strip the legacy parameter—new for gpt-5-chat, gpt-5-chat-2025-08-07, and gpt-5-chat-2025-08-15; gpt-5-chat-2025-10-03 addsmax_tokensto its existingremoveParamsblock (alongsidereasoning_effort).Reviewed by Cursor Bugbot for commit 1e71dbc. Bugbot is set up for automated code reviews on this repo. Configure here.