Skip to content

fix params#1687

Merged
harshiv-26 merged 1 commit into
mainfrom
add-max_tokens-to-remove-params
Jul 3, 2026
Merged

fix params#1687
harshiv-26 merged 1 commit into
mainfrom
add-max_tokens-to-remove-params

Conversation

@harshiv-26

@harshiv-26 harshiv-26 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Provider metadata-only changes with no runtime code; misconfiguration could affect how max output tokens are passed to Azure for these four models.

Overview
Updates four Azure Open AI gpt-5-chat model definitions so output length is configured via max_completion_tokens instead of max_tokens, matching newer Azure/OpenAI chat APIs and the pattern already used on models like gpt-4.1-mini.

Each touched YAML swaps the params key from max_tokens to max_completion_tokens (defaults and max/min bounds unchanged where they existed). removeParams now lists max_tokens so upstream clients strip the legacy parameter—new for gpt-5-chat, gpt-5-chat-2025-08-07, and gpt-5-chat-2025-08-15; gpt-5-chat-2025-10-03 adds max_tokens to its existing removeParams block (alongside reasoning_effort).

Reviewed by Cursor Bugbot for commit 1e71dbc. Bugbot is set up for automated code reviews on this repo. Configure here.

@harshiv-26 harshiv-26 enabled auto-merge (squash) July 3, 2026 08:05

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1e71dbc. Configure here.

Comment thread providers/azure-open-ai/gpt-5-chat-2025-10-03.yaml
@harshiv-26 harshiv-26 merged commit 52ea847 into main Jul 3, 2026
6 checks passed
@harshiv-26 harshiv-26 deleted the add-max_tokens-to-remove-params branch July 3, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants