Skip to content

Reasoning effort fix#1674

Merged
harshiv-26 merged 5 commits into
mainfrom
reasoning-effort-fix
Jul 2, 2026
Merged

Reasoning effort fix#1674
harshiv-26 merged 5 commits into
mainfrom
reasoning-effort-fix

Conversation

@harshiv-26

@harshiv-26 harshiv-26 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Note

Low Risk
Changes are catalog/metadata only (params and removeParams); no runtime code paths. Wrong values could mislead API clients but are easy to spot in config review.

Overview
This PR corrects how reasoning_effort is declared on provider model YAML so clients only see the knob where it applies, with per-model allowed values.

Cohere adds reasoning_effort to default.yaml (default high, none/high) for chat-capable configs, and strips it from embed, rerank, and transcribe models via removeParams.

AWS Bedrock Mantle GPT-OSS chat models now expose reasoning_effort with low/medium/high.

Google Vertex Anthropic chat entries are split: many Opus/Fable/Sonnet variants gain explicit reasoning_effort (defaults and tiers like xhigh/max where relevant), while Haiku 4.5 and Sonnet 4.5 entries remove reasoning_effort so it is not offered on those Vertex routes.

Reviewed by Cursor Bugbot for commit 888a72f. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread providers/google-vertex/anthropic/claude-sonnet-4-5@20250929.yaml Outdated
Comment thread providers/google-vertex/anthropic/claude-sonnet-4-6.yaml

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 21342ca. Configure here.

Comment thread providers/cohere/default.yaml
@harshiv-26 harshiv-26 merged commit 1f67f61 into main Jul 2, 2026
8 checks passed
@harshiv-26 harshiv-26 deleted the reasoning-effort-fix branch July 2, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants