Skip to content

ci(coverage): disable jacoco PR comments, relax overall delta threshold to 0.4% #6695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bladehan1 wants to merge 1 commit into from
+4 −2
Closed

ci(coverage): disable jacoco PR comments, relax overall delta threshold to 0.4% #6695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/pr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ jobs:
min-coverage-overall: 0
min-coverage-changed-files: 0
skip-if-no-changes: true
comment-type: summary
title: '## Base Coverage Snapshot'
update-comment: false

Expand All @@ -300,6 +301,7 @@ jobs:
min-coverage-overall: 0
min-coverage-changed-files: 0
skip-if-no-changes: true
comment-type: summary
title: '## PR Code Coverage Report'
update-comment: false

Expand All @@ -312,7 +314,7 @@ jobs:
set -euo pipefail

MIN_CHANGED=60
MAX_DROP=-0.1
MAX_DROP=-0.4

sanitize() {
echo "$1" | tr -d ' %'
Expand Down Expand Up @@ -386,7 +388,7 @@ jobs:

# 4) Decide CI pass/fail
if [ "$DELTA_OK" -ne 1 ]; then
echo "Coverage gate failed: overall coverage dropped more than 0.1%."
echo "Coverage gate failed: overall coverage dropped more than 0.4%."
echo "base=${BASE_OVERALL}% pr=${PR_OVERALL}% delta=${DELTA}%"
exit 1
fi
Expand Down
Loading