fix(net): fix RejectedExecutionException during shutdown trxHandlePool#6691
Closed
0xbigapple wants to merge 1 commit intotronprotocol:developfrom
Closed
fix(net): fix RejectedExecutionException during shutdown trxHandlePool#66910xbigapple wants to merge 1 commit intotronprotocol:developfrom
0xbigapple wants to merge 1 commit intotronprotocol:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix
RejectedExecutionExceptionduring node shutdown inTransactionsMsgHandler.smartContractExecutorfirst, then consumertrxHandlePool, guaranteeingtrxHandlePoolis alive while the scheduler runs.isClosedflag: early exit inprocessMessage()at entry and during iteration. Covers in-flight messages in the narrow window betweenPeerManager.close()and handler close.RejectedExecutionExceptioncatch: handles TOCTOU race betweenisClosedcheck andsubmit().smartContractQueueandqueueafter both pools terminate.Why are these changes required?
The original
close()shut down the consumer pool (trxHandlePool) before the producer scheduler (smartContractExecutor). During this window,handleSmartContract()was still drainingsmartContractQueueand callingsubmit(trxHandlePool, ...)on an already-terminated pool, throwingRejectedExecutionExceptionand polluting shutdown logs.Thread model
This PR has been tested by:
RejectedExecutionExceptioncontract-msg-handler shutdown donebeforetrx-msg-handler shutdown done)Follow up
N/A
Extra details