Print cost metrics in units#68
Merged
Merged
Conversation
Member
Author
|
Copy of prestodb/presto#11443 |
Member
Author
|
|
kokosing
force-pushed
the
origin/master/063_cost_in_unit
branch
from
b8ee32d to
a69f09a
Compare
martint
approved these changes
Apr 29, 2019
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
One minor comment, but otherwise looks good
Member
There was a problem hiding this comment.
We could use +/- \u221E (∞) here instead of rendering as "Infinity".
Member
There was a problem hiding this comment.
This is not ideal as it uses "data size", which is completely unrelated. Although that class/format doesn't change much, it makes this code brittle. But it will do for now. We can later have a dedicated formatter for cost units.
kokosing
force-pushed
the
origin/master/063_cost_in_unit
branch
from
a69f09a to
aab4bea
Compare
kokosing
force-pushed
the
origin/master/063_cost_in_unit
branch
from
aab4bea to
8b5d658
Compare
voonhous
added a commit
to voonhous/trino
that referenced
this pull request
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print cost metrics in units