Add API specific endpoints for routing rules - #938
Conversation
37b7375 to
fc88400
Compare
|
I like this idea — what do you guys think? |
|
This pull request has gone a while without any activity. Ask for help on #trino-gateway-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
|
I am reopening for @koszti as we still want this fix to go in. Ping us for review please |
|
This pull request has gone a while without any activity. Ask for help on #trino-gateway-dev on Trino slack. |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
mosabua
added
stale-ignore
|
We should get this in .. for now I reopened so it doesnt get lost |
3 participants
Description
Add API specific routing rules endpoints under the API-role
/gatewaysurface:GET /gateway/routing-rules/allPOST /gateway/routing-rules/modify/updateReason: API clients use API-role credentials and routing-rules management should be available on the API-role endpoint surface (not only under
/webappwhich requiresADMINprivileges).Keep existing /webapp routing-rules endpoints for compatibility (no webapp breakage):
GET /webapp/getRoutingRulesPOST /webapp/updateRoutingRulesShare routing-rules logic via RoutingRulesResourceHandler so
/gatewayand/webappuse the same implementation.Update docs/gateway-api.md with the new API-role endpoints and compatibility note.
Additional context and related issues
/gateway/routing-rules/allfor consistency with/gateway/backend/all./gateway endpointsand/webapp/getRoutingRules compatibility.Side note: in the future we could converge on one API surface and treat the web UI as another API client.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required, with the following suggested text:
/gateway/routing-rules/alland/gateway/routing-rules/modify/update, while retaining existing/webapprouting rules endpoints for compatibility.