Content tree - Content tree base component#853
Conversation
|
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new Content Tree component to the Modus Web Components library, implementing the base structure for a hierarchical tree view with support for expansion/collapse, selection, search filtering, and contextual actions. The implementation consists of four sub-components: modus-wc-content-tree (main container), modus-wc-tree-view (list wrapper), modus-wc-tree-item (individual nodes), and modus-wc-tree-actions (action buttons).
Changes:
- Adds new content tree component with search and expand/collapse functionality
- Implements tree item component with checkbox support and subtree management
- Creates tree actions component with dropdown menu for contextual actions
- Includes Storybook stories demonstrating single-select, multi-select, and action modes
- Updates auto-generated type definitions and documentation
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
modus-wc-content-tree.tsx |
Main tree container with search, filtering, and expand/collapse all functionality |
modus-wc-tree-view.tsx |
Wrapper component providing semantic ul element structure |
modus-wc-tree-item.tsx |
Individual tree node with selection, expansion, and action support |
modus-wc-tree-actions.tsx |
Action menu component with dropdown for multiple actions |
*.spec.ts |
Test specifications with invalid prop usage and insufficient coverage |
*.scss |
Styling with CSS syntax error in dark theme selector |
*.stories.ts |
Storybook documentation showing different usage patterns |
| Auto-generated files | TypeScript definitions and custom elements metadata |
addressed except - Increase the line length when expanding an item so that it matches the tree item height due to default styles from daisy ui |
…e-oss/modus-wc-2.0 into 662---content-tree---base
ElishaSamPeterPrabhu
left a comment
There was a problem hiding this comment.
Wrong fallback values on spacing/font variables
The SCSS files use fallback values that don't match the actual variable definitions:
| Variable | Actual value | Fallback used in SCSS |
|---|---|---|
--modus-wc-spacing-xs |
0.25rem (4px) |
0.5rem (8px) |
--modus-wc-spacing-sm |
0.5rem (8px) |
0.75rem (12px) |
--modus-wc-spacing-md |
0.75rem (12px) |
1rem (16px) |
--modus-wc-font-size-md |
0.875rem (14px) |
1rem (16px) |
fallbacks removed |
ElishaSamPeterPrabhu
left a comment
There was a problem hiding this comment.
Moving to QA @jewel-shajan
|
@prashanthr6383 Here are few observations after testing:
|
addressed |
|
This PR cannot be reviewed yet, as it does not align with the issue description. Ongoing offline discussions are still in progress, so this has been moved back to In Progress until a final solution is agreed upon. |
📄 Summary of Changes
💭 Type of Change
📋 Test Plan
✅ Self Code Review Checklist
PR authors and reviewers, please verify that all of these items have been completed.
🔗 Work Item
Issue #662