Skip to content

Fixes for some post-type cases #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trepmal merged 4 commits into from
Jun 5, 2025
Merged

Fixes for some post-type cases #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55bab6f
remove old stopper
trepmal Jun 4, 2025
491a215
add post-type test
trepmal Jun 5, 2025
2a5159a
add test for 0 posts in post-type case
trepmal Jun 5, 2025
ed69de2
accommodate 0 posts in listed post type
trepmal Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"files": [ "revisions-cli.php" ]
},
"require-dev": {
"wp-cli/entity-command": "^1.3 || ^2",
"wp-cli/wp-cli-tests": "^4"
},
"minimum-stability": "dev",
Expand Down
14 changes: 14 additions & 0 deletions features/list.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,17 @@ Feature: Revisions
"""
[]
"""

When I run `wp revisions generate 5 --post_type=page`
And I run `wp revisions list --post_type=page --format=count`
Then STDOUT should contain:
"""
10
"""

When I run `wp post delete $(wp post list --post_type=page --field=ID) --force`
And I run `wp revisions list --post_type=page --format=count`
Then STDOUT should contain:
"""
0
"""
22 changes: 12 additions & 10 deletions inc/class-revisions-cli.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,19 +104,21 @@ function ( $i ) {
wp_parse_slug_list( $assoc_args['post_type'] )
);
$where = sprintf( 'AND post_type IN ( %s )', implode( ',', $post_types ) );

// get all IDs for posts in given post type(s).
$ids = $wpdb->get_col( "SELECT ID FROM $wpdb->posts WHERE 1=2 {$where}" );

// Prepare the IDs for inclusion in the query.
$post__in = array_map( 'esc_sql', $ids );
$post__in = implode( ',', $ids );
$ids = $wpdb->get_col( "SELECT ID FROM $wpdb->posts WHERE 1=1 {$where}" );

// get revisions of those IDs.
$revs = $wpdb->get_results(
"SELECT * FROM $wpdb->posts WHERE post_type = 'revision' AND post_parent IN ({$post__in}) ORDER BY post_parent DESC"
);
if ( $ids ) {
// Prepare the IDs for inclusion in the query.
$post__in = array_map( 'esc_sql', $ids );
$post__in = implode( ',', $ids );

// get revisions of those IDs.
$revs = $wpdb->get_results(
"SELECT * FROM $wpdb->posts WHERE post_type = 'revision' AND post_parent IN ({$post__in}) ORDER BY post_parent DESC"
);
} else {
$revs = [];
}
} else {

$revs = $wpdb->get_results(
Expand Down