Change version of pheonix so that it does not conflict with Erlang 1.9, and fix test#123
Open
tomfbiz wants to merge 7 commits into
Open
Change version of pheonix so that it does not conflict with Erlang 1.9, and fix test#123tomfbiz wants to merge 7 commits into
tomfbiz wants to merge 7 commits into
Conversation
added 6 commits
May 24, 2017 07:24
version updated to the latest stable phoenix 1.2
Also reverted change to TestAddictUserAssociationsSchema from separate branch
in addition to mix.exs and mix.lock, made changes per https://gist.github.com/chrismccord/29100e16d3990469c47f851e3142f766
Author
|
I added changes to make the sample app test run as well. I see this PR has been hanging around for a long time -- any suggestions of how to improve this so it could be merged? Maybe an upgrade to Phoenix 1.3 would be more useful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the tests with Erlang 1.9 was generating compile errors:
Changing versions of phoenix and elixir fixed the issue
Also had to change the order of modules in test\presenter_test.exs to prevent this error:
Made changes to sample application per instructions here:
#Phoenix 1.1.x to 1.2.0 Upgrade Instructions