Skip to content

Change version of pheonix so that it does not conflict with Erlang 1.9, and fix test#123

Open
tomfbiz wants to merge 7 commits into
trenpixster:masterfrom
tomfbiz:phoenix.1.2
Open

Change version of pheonix so that it does not conflict with Erlang 1.9, and fix test#123
tomfbiz wants to merge 7 commits into
trenpixster:masterfrom
tomfbiz:phoenix.1.2

Conversation

@tomfbiz
Copy link
Copy Markdown

@tomfbiz tomfbiz commented May 24, 2017

Running the tests with Erlang 1.9 was generating compile errors:

crash reason: {case_clause,
    {'EXIT',
        {badarg,
            [{erl_anno,anno_info,[-1],[{file,"erl_anno.erl"},{line,360}]},
             {v3_core,record_anno,2,[{file,"v3_core.erl"},{line,2410}]},
             {v3_core,expr,2,[{file,"v3_core.erl"},{line,539}]},
             {v3_core,safe,2,[{file,"v3_core.erl"},{line,1593}]},
             {v3_core,expr,2,[{file,"v3_core.erl"},{line,528}]},
             {v3_core,safe,2,[{file,"v3_core.erl"},{line,1593}]},
             {v3_core,'-safe_list/2-anonymous-0-',2,
                 [{file,"v3_core.erl"},{line,1608}]},
             {lists,foldr,3,[{file,"lists.erl"},{line,1276}]}]}}}

  in function  compile:'-select_passes/2-anonymous-2-'/2 (compile.erl, line 536)
  in call from compile:'-internal_comp/4-anonymous-1-'/2 (compile.erl, line 321)
  in call from compile:fold_comp/3 (compile.erl, line 347)
  in call from compile:internal_comp/4 (compile.erl, line 331)
  in call from compile:'-do_compile/2-anonymous-0-'/2 (compile.erl, line 179)
    (stdlib) lists.erl:1338: :lists.foreach/2
    (phoenix) expanding macro: Phoenix.Router.__before_compile__/1
    test/support/router.exs:1: TestAddictRouter (module)

Changing versions of phoenix and elixir fixed the issue

Also had to change the order of modules in test\presenter_test.exs to prevent this error:

** (UndefinedFunctionError) function TestAddictUserAssociationsSchema.__struct__/0 is undefined
(module TestAddictUserAssociationsSchema is not available)

Made changes to sample application per instructions here:
#Phoenix 1.1.x to 1.2.0 Upgrade Instructions

@tomfbiz tomfbiz changed the title Change version of pheonix so that it does not conflict with Erlang 1.9 Change version of pheonix so that it does not conflict with Erlang 1.9, and fix test May 24, 2017
@tomfbiz
Copy link
Copy Markdown
Author

tomfbiz commented Aug 29, 2017

I added changes to make the sample app test run as well.

I see this PR has been hanging around for a long time -- any suggestions of how to improve this so it could be merged?

Maybe an upgrade to Phoenix 1.3 would be more useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant