Add Loadfilename_as_column_gcs#305
Open
ak-w wants to merge 2 commits into
Open
Conversation
akito19
reviewed
May 17, 2021
| 1. Obtain file names and file contents from multiple files in a specific bucket of GCS. | ||
| the file sample | ||
| name: files_aaa_20210401 | ||
| contents: |
Member
There was a problem hiding this comment.
L10 - L12 lines aren't written in a new line.
So, if you intend to write in other lines, it might need to fix. Would you check it?
Author
There was a problem hiding this comment.
Thank you for your check! I will add the new lines.
akito19
reviewed
May 17, 2021
| # Upload | ||
| $ td wf push gcs_filename_add | ||
|
|
||
| And Set the GCP service account credential to the workflow secret as follows. |
Member
There was a problem hiding this comment.
[nitpick] "set" would be better than "Set".
Author
There was a problem hiding this comment.
Oh, maybe I pasted it from somewhere.
akito19
reviewed
May 17, 2021
|
|
||
| +read_gcsfiles: | ||
| docker: | ||
| image: "digdag/digdag-python:3.9" |
Author
There was a problem hiding this comment.
I checked that it can run without any problems.
Author
|
Sorry for the late. I pushed fixed README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections
digdag/digdag-python:3.9
delete files folder
add file sample to README.md