Lazy AMQP connection and forwarding error logging#5889
Open
mutasimissa wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMQP is the only forwarder that connects synchronously in its constructor. If the broker is unavailable,
factory.newConnection()throws and theRuntimeExceptionpropagates through Guice provisioning, causingSystem.exit(1)— Traccar fails to start entirely.Kafka, MQTT and JSON forwarders don't have this issue because they connect lazily or asynchronously.
This change defers the AMQP connection to the first
publishMessage()call and addschannel.isOpen()checks so forwarding resumes automatically if the broker restarts. Follows the same lazy-connect pattern used inNetworkForwarder.Also adds
LOGGER.warntoEventForwarderAmqpandPositionForwarderAmqpfor forwarding errors, matching existing logging inNetworkForwarderandPositionForwardingHandler.