Fix position handling in filter_label_element and click_select#1910
Merged
HelenaAdrignoli merged 3 commits intorelease/v2.7.0rc1from Apr 15, 2026
Merged
Conversation
Release/v2.7.0rc1
- Remove premature position decrement before filter_label_element call - filter_label_element expects 1-based position and decrements internally - This ensures correct position handling when filtering select elements
HelenaAdrignoli
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
Este PR corrige o fluxo do
ClickSelectno POUI, ajustando a chamada defilter_label_elementpara evitar erro relacionado ao parâmetroposition.O que foi alterado
filter_label_elementdentro declick_select.click_select, mantendo o tratamento de índice centralizado emfilter_label_element.Motivação
Ao executar
ClickSelect, ocorria erro de parâmetropositionna chamada defilter_label_element.A correção garante consistência no uso de posição (1-based na chamada e conversão interna no método de filtro).
Impacto
Validação
click_select.filter_label_elementrecebe os argumentos corretos e não gera mais erro deposition.