Skip to content

test(mobile): use explicit expected values in isServer consistency test#355

Merged
kimyouknow merged 3 commits into
toss:mainfrom
guesung:test/isserver-explicit-assertions
May 13, 2026
Merged

test(mobile): use explicit expected values in isServer consistency test#355
kimyouknow merged 3 commits into
toss:mainfrom
guesung:test/isserver-explicit-assertions

Conversation

@guesung
Copy link
Copy Markdown
Contributor

@guesung guesung commented Apr 1, 2026

Summary

  • Replace relative assertions (toBe(secondCall)) with explicit expected values (toBe(false)) in isServer client-side consistency test
  • Aligns with the pattern used in isServer.ssr.test.ts and getSafeAreaInset.ssr.test.ts

Test plan

  • yarn test passes

Copilot AI review requested due to automatic review settings April 1, 2026 00:48
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the isServer client-side consistency test to assert explicit expected values instead of comparing results across calls, aligning the test style with other SSR-related tests in the repo.

Changes:

  • Replaced relative equality assertions (toBe(secondCall)) with explicit boolean expectations (toBe(false)) for isServer() repeated calls.

Copy link
Copy Markdown
Collaborator

@kimyouknow kimyouknow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2026

⚠️ No Changeset found

Latest commit: 3369fa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kimyouknow kimyouknow merged commit 129c168 into toss:main May 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants