fix(invert/invertBy): skip unsafe properties __proto__ in invert and invertBy#1723
Open
Antoliny0919 wants to merge 1 commit into
Open
fix(invert/invertBy): skip unsafe properties __proto__ in invert and invertBy#1723Antoliny0919 wants to merge 1 commit into
Antoliny0919 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3ffb1fa to
d5aca3b
Compare
Author
|
On reflection, I think the correct behavior is not that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When proto or other special properties are passed as values to
invertandinvertBy, unexpected behavior may occur.expected
{"__proto__": "a", "foo": "b"}Actual
{"foo": "b"}Unlike expected, the key "proto" does not exist.
This behavior is an attempt to assign a value to a special property, but since it is not an actual object, it will not be modified.
Solution
Since only string, number, and symbol(
PropertyKey) types can be used as values, there is no risk of prototype chain pollution.However, it would be worth explicitly notifying users that keys such as
__proto__are ignored.