Skip to content

fix(setToEntries, toKey): improve type safety by using generics and explicit return types #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramong26 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(setToEntries, toKey): improve type safety by using generics and explicit return types #1622

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8ad2b0
fix(setToEntries): handle Set iterator type correctly
ramong26 Feb 18, 2026
3115ad9
fix(toKey): replace any with unknown
ramong26 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/compat/_internal/setToEntries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
export function setToEntries(set: Set<any>) {
const arr = new Array(set.size);
export function setToEntries<T>(set: Set<T>): [T, T][] {
const arr = new Array<[T, T]>(set.size);
const values = set.values();

for (let i = 0; i < arr.length; i++) {
const value = values.next().value;
const value = values.next().value as T;
arr[i] = [value, value];
}

return arr;
}
Loading