Skip to content

fix(trimStart): add missing multi-character string validation #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eunwoo-levi wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −0
Open

fix(trimStart): add missing multi-character string validation #1615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e15a88
fix(trimStart): add missing multi-character string validation
eunwoo-levi Feb 11, 2026
30d52b2
Merge branch 'main' into fix/trimStart-multi-char-validation
eunwoo-levi Mar 22, 2026
3174511
Merge branch 'main' into fix/trimStart-multi-char-validation
eunwoo-levi Apr 10, 2026
9655554
Merge branch 'main' into fix/trimStart-multi-char-validation
eunwoo-levi May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/string/trimStart.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ describe('trimStart', () => {
expect(trimStart(' hello world ')).toEqual('hello world ');
});

it('should throw an error when chars is a multi-character string', () => {
expect(() => trimStart('---hello', '--')).toThrow();
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test should verify the exact error message for consistency with the trimEnd tests. The trimEnd.spec.ts file (line 66) tests the exact error message with: expect(() => trimEnd('hello', 'ab')).toThrow(\The 'chars' parameter should be a single character string.`);` This test should follow the same pattern.

Copilot uses AI. Check for mistakes.
});
Comment on lines +49 to +51
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test case for an empty string as the chars parameter (e.g., trimStart('hello', '')). This would also trigger the validation error since an empty string has length 0, not 1. While trimEnd.spec.ts also lacks this test case, adding it here would improve edge case coverage.

Copilot uses AI. Check for mistakes.

it('should remove leading characters when chars is an array', () => {
expect(trimStart('---hello', ['-', 'h'])).toEqual('ello');
});
Expand Down
4 changes: 4 additions & 0 deletions src/string/trimStart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export function trimStart(str: string, chars?: string | string[]): string {

switch (typeof chars) {
case 'string': {
if (chars.length !== 1) {
throw new Error(`The 'chars' parameter should be a single character string.`);
}

while (startIndex < str.length && str[startIndex] === chars) {
startIndex++;
}
Expand Down
Loading