Skip to content

[PF-1994] Migrate Button to @base-ui/react + Tailwind#4947

Open
vedrani wants to merge 4 commits into
feature/picasso-modernization-tempfrom
migrate-Button
Open

[PF-1994] Migrate Button to @base-ui/react + Tailwind#4947
vedrani wants to merge 4 commits into
feature/picasso-modernization-tempfrom
migrate-Button

Conversation

@vedrani
Copy link
Copy Markdown
Collaborator

@vedrani vedrani commented May 8, 2026

Button migration diff

Generated: 2026-05-08 08:39:43 CEST

Package: packages/base/Button

Files

No file additions, deletions, or renames.

Imports

Removed:

packages/base/Button/src/Button/Button.tsx:import { noop } from '@toptal/picasso-utils'
packages/base/Button/src/ButtonBase/ButtonBase.tsx:import { Button as MUIButtonBase } from '@mui/base/Button'
packages/base/Button/src/ButtonBase/ButtonBase.tsx:import type { ButtonRootSlotProps } from '@mui/base/Button'

Added:

packages/base/Button/src/Button/Button.tsx:import { noop, withClasses } from '@toptal/picasso-utils'
packages/base/Button/src/ButtonBase/ButtonBase.tsx:import { Button as BaseUIButton } from '@base-ui/react/button'

MUI v4 / JSS residue check

Check Count
@material-ui/* source imports 0
JSS calls (makeStyles/createStyles/withStyles) 0
@material-ui/core in package.json 0
0

Migration is NOT complete until all three are 0.

package.json delta

@@ -32,7 +32,7 @@
     "@toptal/picasso-utils": "4.0.0",
     "@toptal/picasso-link": "4.0.0",
     "ap-style-title-case": "^1.1.2",
-    "@mui/base": "5.0.0-beta.58",
+    "@base-ui/react": "^1.4.1",
     "classnames": "^2.5.1"
   },
   "sideEffects": [
@@ -43,7 +43,7 @@
     "@toptal/picasso-tailwind-merge": "^2.0.0",
     "@toptal/picasso-tailwind": ">=2.7",
     "@toptal/picasso-provider": "*",
-    "react": ">=16.12.0 < 19.0.0"
+    "react": ">=16.12.0"
   },
   "exports": {
     ".": "./dist-package/src/index.js"

Prop-surface diff

Click to expand .d.ts diff

Review carefully: any - line on a public export is a breaking change. See docs/migration/rules/api-preservation.md.

Happo

Happo log: migration-runs/2026-05-08/Button/happo.log (0
? flagged lines).

Designer: review screen diffs >0.5% per docs/migration/migration-plan.md §6.3.

React 19 smoke

Stubbed (pending PF-1994). The real smoke wires up during PF-1994's first migration.

@vedrani vedrani requested a review from a team as a code owner May 8, 2026 06:39
@vedrani vedrani self-assigned this May 8, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

⚠️ No Changeset found

Latest commit: 0cf0c6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4947/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 8, 2026
Comment thread packages/base/Button/src/Button/Button.tsx Outdated
Comment thread packages/base/Button/src/Button/Button.tsx Outdated
Comment thread packages/base/Button/src/ButtonBase/ButtonBase.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4947/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

📖 Storybook Preview

🚀 Your Storybook preview is ready: View Storybook

📍 Preview URL: https://toptal.github.io/picasso/prs/4947/

This preview is updated automatically when you push changes to this PR.

github-actions Bot added a commit that referenced this pull request May 11, 2026
@vedrani vedrani force-pushed the feature/pf-1992-migration-orchestrator branch from 6c32b4e to 8a68876 Compare May 12, 2026 12:05
@vedrani vedrani changed the base branch from feature/pf-1992-migration-orchestrator to feature/picasso-modernization-temp May 12, 2026 12:08
@vedrani vedrani force-pushed the migrate-Button branch 2 times, most recently from d0f642d to a808925 Compare May 12, 2026 15:36
vedrani added 3 commits May 12, 2026 18:31
Tier 0 component. See PR description for prop-surface diff,
import diff, and Happo summary.

Refs: PF-1994
Tier 0 component. See PR description for prop-surface diff,
import diff, and Happo summary.

Refs: PF-1994

[review-iter 3] address review feedback
Tier 0 component. See PR description for prop-surface diff,
import diff, and Happo summary.

Refs: PF-1994

[review-iter 5] address review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants