Skip to content

Return null instead of [] for empty <AttributeValue /> #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sambostock wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Return null instead of [] for empty <AttributeValue /> #533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d85a5db
Fix formatting typo
sambostock Jan 8, 2024
0f731c5
Add missing attribute to xml
sambostock Jan 9, 2024
98cc61f
Add test for valueless attribute
sambostock Jan 8, 2024
dc61323
Return `null` instead of `[]` for valueless attribute
sambostock Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/metadata-distribution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

?> Metadata is used to exchange information between Identity Provider and Service Provider. Simply there are two major ways to exchange Metadata.

**Release in public **
Copy link
Copy Markdown
Author

@sambostock sambostock Jan 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to notice this while looking for contribution docs. Happy to extract it into another PR if appropriate.

**Release in public**

Display the Metadata in a specific URL. Everyone has the URL can watch the Metadata. Therefore, the Metadata is distributed publicly. We provide an API to do it once you've configure your SP.

Expand Down