Conversation
Add es_ES locale (verified)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for adding Spanish — the project only has en/sk/zh-Hans/zh-Hant right now.
That said, the translation needs some work before it's ready to merge. I went through the Localizable.xcstrings diff and found a few issues:
Partially translated entries — Several strings have only the first word or verb translated while the rest stays in English. For example:
"Limpiar input when translating"(should be fully Spanish)"Ocultar Menu Bar Icon""Abrir in Apple Dictionary""Traducir the following ${{queryFromLanguage}} text into ${{queryTargetLanguage}}: ${{queryText}}""Habilitar Force Get Selected Text""Habilitar OCR Text Format Optimization"
There are about 10+ entries like this. They look like an interrupted pass — the first verb got translated but the sentence wasn't finished.
Formatting changes — The diff is ~15k lines but a big chunk is just whitespace reformatting ("value" : → "value":) across existing en/sk/zh entries. This makes the diff hard to review and could cause merge conflicts. Would be better to keep only the actual es additions.
58 entries identical to English — Some are fine (brand names like "DeepL", "Baidu"), but others like "Buffer Too Small" or "Decode Error" should probably be translated.
Could you do another pass on the incomplete translations.
Fix the incomplete translations
|
Please review "The Fix the incomplete translations" |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19b3158642
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Rename to kebab-case and Add missing Spanish localization for Claude service label
Fix rename
Fix name es
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41a910b6ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| case simplifiedChinese = "zh-Hans" | ||
| case traditionalChinese = "zh-Hant" | ||
| case slovak = "sk" | ||
| case spanish = "es" |
There was a problem hiding this comment.
Adding .spanish here makes Spanish selectable app-wide, but Localizable.xcstrings in this commit still has no es entries for user-visible keys that are actively used (for example service.configuration.custom_openai.enable_streaming.title, service.configuration.validation_success.streaming_disabled, and error.content_type.* referenced in StreamConfigurationView, BaseOpenAIService, and StreamService+UpdateResult). Spanish users will therefore get a mixed Spanish/English UI and diagnostics whenever those flows are hit. Fresh evidence beyond prior comments: these additional OpenAI-related keys remain untranslated in this commit.
Useful? React with 👍 / 👎.
2 participants
Add es_ES locale (verified)