⏱️ Bound search-test CI runtime so a stuck install can't hang for hours#345
Closed
joshbermanssw wants to merge 2 commits into
Closed
⏱️ Bound search-test CI runtime so a stuck install can't hang for hours#345joshbermanssw wants to merge 2 commits into
joshbermanssw wants to merge 2 commits into
Conversation
The search-tests job had no timeout, so when the "Install Playwright browsers" step hung it sat in_progress for ~2h (GitHub's 6h default before auto-fail), holding the PR check pending. Add a 15-min job timeout and an 8-min cap on the install step so a hang fails fast and visibly instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…ut + retry The install step wedges intermittently when `--with-deps` blocks on the runner's apt/dpkg lock. A plain retry can't help because a hang is not a non-zero exit. Wrap each attempt in `timeout 180` so a stuck apt is killed, then retry up to 3 times to ride out the transient lock — all inside the existing 8-minute step budget. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #346, which includes this CI hang fix alongside the search.tsx fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The
search-testsjob has no timeout, so when "Install Playwright browsers" hung today it satin_progressfor ~2 hours (GitHub's 6h default before auto-fail), leaving the PR check stuckpending. This adds a 15-minute job timeout and an 8-minute cap on the install step so a hang fails fast instead of blocking PRs for hours.Why
Three runs today (across PR #342 and #343, unrelated branches) all froze on the same install step while every prior run finished in minutes — a stuck infra step, not a test failure. With no
timeout-minutes, GitHub lets it run up to 6h before failing, so the check never goes red in any useful timeframe.How
timeout-minutes: 15on thetest-searchjob.timeout-minutes: 8on the "Install Playwright browsers" step, so the most likely hang point fails first with a clear cause.The install command is unchanged — it has worked in every prior run, so this is purely a guardrail, not a behavior change.
Tests
Config-only change; validated by the next
deployment_status-triggered run completing (or failing fast) within the new bounds.