Skip to content

build: add ros_testing as buildtool/test_depend#446

Open
mojomex wants to merge 2 commits into
mainfrom
build/nebula-depend-on-ros-testing
Open

build: add ros_testing as buildtool/test_depend#446
mojomex wants to merge 2 commits into
mainfrom
build/nebula-depend-on-ros-testing

Conversation

@mojomex
Copy link
Copy Markdown
Collaborator

@mojomex mojomex commented May 26, 2026

PR Type

  • Improvement

Description

ROS 2 buildfarm is currently failing on nebula:

CMake Error at CMakeLists.txt:8 (find_package):
  By not providing "Findros_testing.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "ros_testing", but CMake did not find one.

  Could not find a package configuration file provided by "ros_testing" with
  any of the following names:

    ros_testingConfig.cmake
    ros_testing-config.cmake

  Add the installation prefix of "ros_testing" to CMAKE_PREFIX_PATH or set
  "ros_testing_DIR" to a directory containing one of the above files.  If
  "ros_testing" provides a separate development package or SDK, be sure it
  has been installed.


-- Configuring incomplete, errors occurred!

This PR adds ros_testing as buildtool_depend for the CMake macros, and test_depend for test-time libs.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
@mojomex mojomex self-assigned this May 26, 2026
@mojomex mojomex requested a review from drwnz May 28, 2026 05:40
Copy link
Copy Markdown
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants