Open
Conversation
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
taras
reviewed
Nov 13, 2023
| }, | ||
| }, | ||
| }, | ||
| } as Resolvers, |
Member
Member
Author
There was a problem hiding this comment.
Yeah, you are right. It's better to declare resolvers:
const resolvers: Resolvers = { /* ... */ }
Member
There was a problem hiding this comment.
Another option is to wrap createModule() to require the type of resolvers to be Resolvers. Another pattern I've become fond of is to use a function:
function moduleResolvers(): Resolvers {
}and then invoke it like:
createModule({
id: "starwars",
dirname: import.meta.url,
resolvers: moduleResolvers(),
});Or as something that can be spread in:
function moduleResolvers(): { resolvers: Resolvers } {
//....
}createModule({
id: "starwars",
dirname: import.meta.url,
...moduleResolvers(),
});
Member
There was a problem hiding this comment.
I'm happy with the ...moduleResolvers() or moduleResolves() - both work fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GraphQL Yoga example doesn't have codegen config
Approach
Add simple codegen config and use generated types in GraphQL resolvers
Possible Drawbacks or Risks
The example is pretty simple, so it doesn't show potential issues with generated types