Skip to content

Remove foreman::cli::virt_who_configure#1061

Merged
evgeni merged 1 commit into
theforeman:developfrom
ogajduse:fix/remove-virt-who-configure-cli
Jun 16, 2026
Merged

Remove foreman::cli::virt_who_configure#1061
evgeni merged 1 commit into
theforeman:developfrom
ogajduse:fix/remove-virt-who-configure-cli

Conversation

@ogajduse

Copy link
Copy Markdown
Member

The foreman::cli::virt_who_configure class was removed from puppet-foreman
in theforeman/puppet-foreman@f345cfa, breaking nightly builds:

File not found .../foreman/manifests/cli/virt_who_configure.pp, check your answer file (KafoParsers::ModuleName)

This PR:

  • Removes the class from katello-answers.yaml
  • Adds a migration to clean up existing answer files
  • Removes the stale line from the 190710133444-add-virt-who migration
  • Updates spec fixtures

Comment thread config/katello.migrations/190710133444-add-virt-who.rb
The puppet-foreman module dropped the
foreman::cli::virt_who_configure class (theforeman/puppet-foreman@f345cfa),
causing foreman-installer nightly builds to fail with:

  File not found .../foreman/manifests/cli/virt_who_configure.pp

Remove the class from the katello scenario answers, add a migration
to clean up existing answer files, and update spec fixtures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ogajduse ogajduse force-pushed the fix/remove-virt-who-configure-cli branch from 2025c71 to 9d44d18 Compare June 16, 2026 08:56
@ogajduse ogajduse requested a review from evgeni June 16, 2026 08:58

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ

@evgeni evgeni merged commit 12f5b84 into theforeman:develop Jun 16, 2026
11 of 12 checks passed
@ogajduse ogajduse deleted the fix/remove-virt-who-configure-cli branch June 16, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants