improved the spelling and grammar of hooks/boot/02-message-helpers.rb#1059
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refines the wording and formatting of user-facing installer messages in the boot message helpers, making them clearer and grammatically correct.
Changes:
- Restructures the dev server success message into a bulleted sub-list for readability.
- Improves the certs-generate message grammar and clarifies its purpose.
- Tweaks failure and log message wording for clarity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ianballou
approved these changes
May 18, 2026
ianballou
left a comment
ianballou
left a comment
Contributor
There was a problem hiding this comment.
I haven't run this, but it looks fine to me.
chris1984
approved these changes
May 19, 2026
Member
|
Might be worth looking to see if there is bats test that check for wording, I am guessing downstream we assert the wording somewhere too. |
ehelms
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After installing multiple servers, i found the below message increasingly annoying and now i changed it and some other lines as well :)
* To install an additional Foreman proxy on separate machine continue by running: