Fixed CRHTTPConnection query URL parsing#71
Open
itsjunetime wants to merge 1 commit intothecatalinstan:masterfrom
Open
Fixed CRHTTPConnection query URL parsing#71itsjunetime wants to merge 1 commit intothecatalinstan:masterfrom
itsjunetime wants to merge 1 commit intothecatalinstan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CRHTTPConnection.m, the query URL that is being constructed from the HTTP data isn't being percent encoded. This means that if it includes some special characters such as backticks or carets, the
NSURLthat is constructed will benil, and the server won't be able to correctly handle the request.This PR simply adds percent encoding so that it correctly sets the URL, and services the request as expected.