fix(x11/cinnamon): guard remaining virtualKeyboardManager references in cinnamon#28801
Merged
robertkirkman merged 1 commit intotermux:masterfrom Mar 5, 2026
Conversation
Contributor
sabamdarif
commented
Mar 5, 2026
sabamdarif
commented
- it will fix the issue that was cauing this error
…in cinnamon - it will fix the issue that was cauing this error ``` (cinnamon:9449): Cjs-CRITICAL **: 19:05:13.867: JS ERROR: TypeError: Main.virtualKeyboardManager is undefined _updateVisibility@/data/data/com.termux/files/usr/share/cinnamon/js/ui/ibusCandidatePopup.js:304:25 setPanelService/<@/data/data/com.termux/files/usr/share/cinnamon/js/ui/ibusCandidatePopup.js:248:18 ```
Member
|
Thank you it's great, we can merge things that have the but the rest of that PR takes a really long time to build so it's just taking longer before it's done building |
sabamdarif
force-pushed
the
cleanup-cinnamon-virtualKeyboardManager-leftover
branch
from
c2c3328 to
1dcce7e
Compare
robertkirkman
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.