fix(x11/cinnamon-session): change Python dependencies to match other distros

[robertkirkman]

• In Arch Linux and Debian, cinnamon-session depends on pygobject and setproctitle, but does not depend on psutil or inotify there.

• Prevents error during pkg install cinnamon-session inotify is not available on android-24-arm64_v8a

[robertkirkman]

@sabamdarif do you know why cinnamon-session needed to depend on psutil, python-dbus, pyinotify and pyinotify-elephant-fork, or what distro you looked at which had those dependencies marked on cinnamon-session?

[robertkirkman]

@DuilioPerez I can see that you decided those dependencies,

could you explain how you found them, and also, if there were commands that were broken without those dependencies installed, could you show what commands those were, so I can test the commands on Arch Linux Cinnamon and check why Arch Linux doesn't have the same problems (or if it does)?

[sabamdarif]

@sabamdarif do you know why cinnamon-session needed to depend on psutil, python-dbus, pyinotify and pyinotify-elephant-fork, or what distro you looked at which had those dependencies marked on cinnamon-session?

it doesn't need this on build time, but when i was trying to launch it it shows me some errors when get fixed after i install this modules , it was disused here :- #25823 (comment) , i don't actually remember what the error was

[robertkirkman]

@sabamdarif do you know why cinnamon-session needed to depend on psutil, python-dbus, pyinotify and pyinotify-elephant-fork, or what distro you looked at which had those dependencies marked on cinnamon-session?

it doesn't need this on build time, but when i was trying to launch it it shows me some errors when get fixed after i install this modules , it was disused here :- #25823 (comment) , i don't actually remember what the error was

Since pyinotify will not work anymore, but you are someone who could reproduce the original errors, could you download the artifact from this PR and check whether you can still reproduce the original errors when using the version from this PR?

[sabamdarif]

wait, i will try it now

[sabamdarif]

it needs python-psutil, let me check other

[robertkirkman]

Ok I will add python-psutil

[sabamdarif]

wait few minutes let me reset my termux , it's too bloated , i think that's why it's not launching because there are no more i can see

[sabamdarif]

it's app data is over 25gb now i should clean it up now

[sabamdarif]

it's working

[sabamdarif]

although there is a issue , although this isn't related to this pr , the issue is it can't load backgrounds from gnome-backgrounds

[robertkirkman]

I will try to fix it

[sabamdarif]

ok while you are doing this can patch js/ui/ibusCandidatePopup.js in cinnamon package too there are some places where it still call virtualKeyboardManager can you disable them

             for (let i = 0; (indexLabel = lookupTable.get_label(i)); ++i)
                 indexes.push(indexLabel.get_text());
 
-            Main.virtualKeyboardManager.resetSuggestions();
+            if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.resetSuggestions();
 
             let candidates = [];
             for (let i = startIndex; i < endIndex; ++i) {
                candidates.push(lookupTable.get_candidate(i).get_text());
-                Main.virtualKeyboardManager.addSuggestion(lookupTable.get_candidate(i).get_text(), () => {
+                if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.addSuggestion(text, () => {
                     let index = i;
                     this._panelService.candidate_clicked(index, 1, 0);
                 });

       panelService.connect('focus-out', () => {
            this.close(BoxPointer.PopupAnimation.NONE);
-            Main.virtualKeyboardManager.resetSuggestions();
+            if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.resetSuggestions();
        });
    }
    

         _updateVisibility() {
-        let isVisible = !Main.virtualKeyboardManager.visible &&
+        let isVisible = !(Main.virtualKeyboardManager && Main.virtualKeyboardManager.visible) &&
                          (this._preeditText.visible ||
                           this._auxText.visible ||
                           this._candidateArea.visible);
                           

the patch could be, something like this , and it will be inside https://github.com/termux/termux-packages/blob/master/x11-packages/cinnamon/0011-disable-virtualkeyboard.patch file

[sabamdarif]

I will try to fix it

i think you should marge it , otherwise people will not be able to install cinnamon , and that issue is with the cinnamon package not with cinnamon-session

[DuilioPerez]

@DuilioPerez I can see that you decided those dependencies,

could you explain how you found them, and also, if there were commands that were broken without those dependencies installed, could you show what commands those were, so I can test the commands on Arch Linux Cinnamon and check why Arch Linux doesn't have the same problems (or if it does)?

I don't remember where is used. But it seems it's used by nemo for desktop

[robertkirkman]

I will try to fix it

i think you should marge it , otherwise people will not be able to install cinnamon , and that issue is with the cinnamon package not with cinnamon-session

I don't remember where is used. But it seems it's used by nemo for desktop

oh no

well I will merge this now for cinnamon-session then and it sounds like those other changes should actually be in other packages

[DuilioPerez]

@sabamdarif do you know why cinnamon-session needed to depend on psutil, python-dbus, pyinotify and pyinotify-elephant-fork, or what distro you looked at which had those dependencies marked on cinnamon-session?

it doesn't need this on build time, but when i was trying to launch it it shows me some errors when get fixed after i install this modules , it was disused here :- #25823 (comment) , i don't actually remember what the error was

Since pyinotify will not work anymore, but you are someone who could reproduce the original errors, could you download the artifact from this PR and check whether you can still reproduce the original errors when using the version from this PR?

Yes, it seems is not used in this version. It was used when I tested cinnamon for the first time, but now it seems is not needed

[robertkirkman]

ok while you are doing this can patch js/ui/ibusCandidatePopup.js in cinnamon package too there are some places where it still call virtualKeyboardManager can you disable them

             for (let i = 0; (indexLabel = lookupTable.get_label(i)); ++i)
                 indexes.push(indexLabel.get_text());
 
-            Main.virtualKeyboardManager.resetSuggestions();
+            if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.resetSuggestions();
 
             let candidates = [];
             for (let i = startIndex; i < endIndex; ++i) {
                candidates.push(lookupTable.get_candidate(i).get_text());
-                Main.virtualKeyboardManager.addSuggestion(lookupTable.get_candidate(i).get_text(), () => {
+                if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.addSuggestion(text, () => {
                     let index = i;
                     this._panelService.candidate_clicked(index, 1, 0);
                 });

       panelService.connect('focus-out', () => {
            this.close(BoxPointer.PopupAnimation.NONE);
-            Main.virtualKeyboardManager.resetSuggestions();
+            if (Main.virtualKeyboardManager) Main.virtualKeyboardManager.resetSuggestions();
        });
    }
    

         _updateVisibility() {
-        let isVisible = !Main.virtualKeyboardManager.visible &&
+        let isVisible = !(Main.virtualKeyboardManager && Main.virtualKeyboardManager.visible) &&
                          (this._preeditText.visible ||
                           this._auxText.visible ||
                           this._candidateArea.visible);
                           

the patch could be, something like this , and it will be inside https://github.com/termux/termux-packages/blob/master/x11-packages/cinnamon/0011-disable-virtualkeyboard.patch file

Wait, that is also in cinnamon too isn't it?

Could you put that in a different PR for cinnamon and I will approve it?

[sabamdarif]

ok, they are not a big issue the it's just shows a error but the desktop still launch