per-key rate limit should block at priority level, not whole queue#10188
Draft
majiru wants to merge 1 commit intotemporalio:mainfrom
Draft
per-key rate limit should block at priority level, not whole queue#10188majiru wants to merge 1 commit intotemporalio:mainfrom
majiru wants to merge 1 commit intotemporalio:mainfrom
Conversation
When findAndWakeMatches found a rate-limited task it set a retry timer and returned immediately, stalling every task behind it regardless of fairness key. A high-priority key1 task being throttled would block a ready key2 task from dispatching until the timer fired. The fix moves the rate-limit check inside findMatch. The inner poller loop now saves the first compatible poller in `matched` rather than returning immediately. After finding a poller, the task's rate-limit delay is checked: if positive the task is skipped and its delay contributes to a running `minDelay`; if zero the match is returned. findMatch gains a third return value carrying minDelay back to findAndWakeMatches, which uses it to set the retry timer only when there are no ready matches at all — and only to the earliest time any blocked task (that actually has a compatible poller) becomes ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When findAndWakeMatches found a rate-limited task it set a retry timer and returned immediately, stalling every task behind it regardless of fairness key. A high-priority key1 task being throttled would block a ready key2 task from dispatching until the timer fired.
The fix moves the rate-limit check inside findMatch. The inner poller loop now saves the first compatible poller in
matchedrather than returning immediately. After finding a poller, the task's rate-limit delay is checked: if positive the task is skipped and its delay contributes to a runningminDelay; if zero the match is returned. findMatch gains a third return value carrying minDelay back to findAndWakeMatches, which uses it to set the retry timer only when there are no ready matches at all — and only to the earliest time any blocked task (that actually has a compatible poller) becomes ready.How did you test it?