Skip to content

Check only principal type for system worker classification #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rkannan82 merged 1 commit into from
May 8, 2026
+5 −5
Merged

Check only principal type for system worker classification #10172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions service/matching/workers/registry_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,11 @@ func (m *registryImpl) DescribeWorker(nsID namespace.ID, workerInstanceKey strin

// isSystemWorker determines if a worker is a system worker.
// If a principal is available, it checks whether the principal identifies
// the Temporal server itself (type="temporal", name="internal"). Otherwise,
// it falls back to checking the task queue name prefix.
// the Temporal server itself (type="temporal"). Otherwise, it falls back to
// checking the task queue name prefix.
func isSystemWorker(principal *commonpb.Principal, taskQueue string) bool {
if principal != nil {
return principal.GetType() == authorization.InternalPrincipalType && principal.GetName() == authorization.InternalPrincipalName
return principal.GetType() == authorization.InternalPrincipalType
}
return primitives.IsInternalTaskQueue(taskQueue)
}
4 changes: 2 additions & 2 deletions service/matching/workers/registry_impl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func TestIsSystemWorker(t *testing.T) {
require.Len(t, list, 1)
})

t.Run("principal with type temporal but non-internal name is not system worker", func(t *testing.T) {
t.Run("principal with type temporal but non-internal name is still system worker", func(t *testing.T) {
m := newRegistryImpl(testDefaultRegistryParams(metrics.NoopMetricsHandler))
defer m.Stop()

Expand All @@ -240,7 +240,7 @@ func TestIsSystemWorker(t *testing.T) {
})

list := m.filterWorkers("ns", false /* includeSystemWorkers */, alwaysTrue)
require.Len(t, list, 1, "worker with non-internal name should not be excluded")
require.Empty(t, list, "worker with temporal principal type should be excluded regardless of name")
})

t.Run("principal with non-temporal type is not system worker", func(t *testing.T) {
Expand Down
Loading