Add memo update support for schedules#2325
Open
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Open
Add memo update support for schedules#2325chaptersix wants to merge 2 commits intotemporalio:mainfrom
chaptersix wants to merge 2 commits intotemporalio:mainfrom
Conversation
Add a Memo field to ScheduleUpdate that allows updating the schedule-level memo via UpdateScheduleRequest. Uses pointer-to-map semantics: nil means don't update, non-nil empty map clears, non-nil with entries replaces. This feature is only supported on CHASM-backed schedules. Attempting to update memo on a workflow-backed schedule returns a FailedPrecondition error. Also enables the chasm-scheduler experiment in dev server and CI dynamic config so integration tests can create CHASM-backed schedules via the temporal-experiment gRPC header.
chaptersix
force-pushed
the
sch-update-memo
branch
from
f800ee8 to
2ee4a1f
Compare
chaptersix
force-pushed
the
sch-update-memo
branch
from
0fdf439 to
f0a10f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memofield toScheduleUpdateto allow updating schedule-level memo viaUpdateScheduleRequestnil= don't update, non-nil empty map = clear, non-nil with entries = replaceFailedPreconditionerrorfrontend.allowedExperimentsconfig in dev server and CI so integration tests can create CHASM schedules via thetemporal-experimentgRPC headerDepends on API change: temporalio/api#748