Prefer Class-File API on Java 24 or above - #391
Open
Goooler wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
============================================
+ Coverage 79.07% 81.43% +2.35%
Complexity 72 72
============================================
Files 6 6
Lines 239 237 -2
Branches 27 27
============================================
+ Hits 189 193 +4
+ Misses 37 31 -6
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thanks for the contribution - but we cannot just increase the minimum java version to 24 or even 25. |
Contributor
Author
|
See #383 (comment). |
Owner
Yeah, but the PR is just on main. We would need a strategy how to handle this. |
Contributor
Author
|
There could be 2 branches for maintaining, v2 and v3, e.g. https://github.com/GradleUp/shadow
|
Contributor
Author
|
Alternatively, we can provide a multi-release jar. See JakeWharton/diffuse#477. |
Goooler
force-pushed
the
migrate-to-class-file-api
branch
from
June 13, 2026 11:05
6b4a34b to
e25eda7
Compare
Goooler
force-pushed
the
migrate-to-class-file-api
branch
2 times, most recently
from
June 13, 2026 11:16
54a593f to
47d9554
Compare
Goooler
force-pushed
the
migrate-to-class-file-api
branch
from
August 9, 2026 03:06
47d9554 to
74d931f
Compare
Goooler
force-pushed
the
migrate-to-class-file-api
branch
from
August 9, 2026 03:26
74d931f to
013bd19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #383.