Skip to content

(data): Move thirdParty into variants for Base Set #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lamplis wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

(data): Move thirdParty into variants for Base Set #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e066d9
fix(data/Base Set): move thirdParty ids to variant level and normaliz…
lamplis Apr 22, 2026
1f25947
fix(data/Base Set): align variant marketplace mapping with review fee…
lamplis May 6, 2026
8858ffb
fix(data/Base Set): align Base Set ids with print order
lamplis May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions data/Base/Base Set/1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,27 @@ const card: Card = {
variants: [
{
type: "holo",
Copy link
Copy Markdown
Contributor

@thomas-bassett thomas-bassett May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we messing with the order of variants? apart from moving the 1st edition print as disccused before there shouldnt be a need for any other change

subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
Copy link
Copy Markdown
Contributor

@thomas-bassett thomas-bassett May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still missing thirdparty ids. there might be some obvious ones that wont have ids but holo-unlimited definatly should have one

},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273696,
tcgplayer: 42346
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660227
}
}
],

Expand All @@ -108,10 +115,6 @@ const card: Card = {
it: "Il suo cervello è più potente di un supercomputer. Dicono che abbia un quoziente di intelligenza di 5.000. LIV 42 N.65"
},

thirdParty: {
cardmarket: 273696,
tcgplayer: 42346
}
}

export default card
19 changes: 11 additions & 8 deletions data/Base/Base Set/10.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,28 +83,31 @@ const card: Card = {
variants: [
{
type: "holo",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273705,
tcgplayer: 42347
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660218
}
}
],


thirdParty: {
cardmarket: 273705,
tcgplayer: 42347
}
}

export default card
19 changes: 11 additions & 8 deletions data/Base/Base Set/100.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,30 @@ const card: Card = {
stage: "Basic",
energyType: "Normal",

thirdParty: {
cardmarket: 273795,
tcgplayer: 42348
},
variants: [
{
type: "normal",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273795,
tcgplayer: 42348
}
},
{
type: "normal",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660101
}
}
],
}
Expand Down
19 changes: 11 additions & 8 deletions data/Base/Base Set/101.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,30 @@ const card: Card = {
stage: "Basic",
energyType: "Normal",

thirdParty: {
cardmarket: 273796,
tcgplayer: 42349
},
variants: [
{
type: "normal",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273796,
tcgplayer: 42349
}
},
{
type: "normal",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660098
}
}
],
}
Expand Down
19 changes: 11 additions & 8 deletions data/Base/Base Set/102.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,27 +16,30 @@ const card: Card = {
stage: "Basic",
energyType: "Normal",

thirdParty: {
cardmarket: 273797,
tcgplayer: 42350
},
variants: [
{
type: "normal",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "normal",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273797,
tcgplayer: 42350
}
},
{
type: "normal",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660096
}
}
],
}
Expand Down
19 changes: 11 additions & 8 deletions data/Base/Base Set/11.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,28 +92,31 @@ const card: Card = {
variants: [
{
type: "holo",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273706,
tcgplayer: 42351
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660217
}
}
],


thirdParty: {
cardmarket: 273706,
tcgplayer: 42351
}
}

export default card
19 changes: 11 additions & 8 deletions data/Base/Base Set/12.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,27 @@ const card: Card = {
variants: [
{
type: "holo",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273707,
tcgplayer: 42352
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660216
}
}
],

Expand All @@ -109,10 +116,6 @@ const card: Card = {
it: "Molto intelligente, ma anche molto vendicativo. Chi osa afferrare una delle sue numerose code viene punito con una maledizione che durerà 1.000 anni. LIV 32 N.38"
},

thirdParty: {
cardmarket: 273707,
tcgplayer: 42352
}
}

export default card
19 changes: 11 additions & 8 deletions data/Base/Base Set/13.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,28 +93,31 @@ const card: Card = {
variants: [
{
type: "holo",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273708,
tcgplayer: 42353
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660215
}
}
],


thirdParty: {
cardmarket: 273708,
tcgplayer: 42353
}
}

export default card
19 changes: 11 additions & 8 deletions data/Base/Base Set/14.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,28 +93,31 @@ const card: Card = {
variants: [
{
type: "holo",
subtype: "unlimited",
subtype: "1999-2000-copyright",
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"]
subtype: "unlimited"
},
{
type: "holo",
subtype: "shadowless",
stamp: ["1st-edition"],
thirdParty: {
cardmarket: 273709,
tcgplayer: 42354
}
},
{
type: "holo",
subtype: "1999-2000-copyright",
subtype: "shadowless",
thirdParty: {
cardmarket: 660214
}
}
],


thirdParty: {
cardmarket: 273709,
tcgplayer: 42354
}
}

export default card
Loading
Loading