Skip to content

Fix invalid Elixir version installs #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RuyiLi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix invalid Elixir version installs #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions kiex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,13 +551,13 @@ function get_latest() {

function valid_known_release() {
ver="$1"
get_known_elixir_releases | grep -q "$1$" 2> /dev/null
get_known_elixir_releases | sed 's/^[[:space:]]*//' | grep -Fqx -- "$ver" 2> /dev/null
echo $?
}

function valid_branch() {
ver="$1"
get_elixir_branches | grep -q "$1" 2> /dev/null
get_elixir_branches | sed 's/^[[:space:]]*//' | grep -Fqx -- "$ver" 2> /dev/null
echo $?
}

Expand Down Expand Up @@ -623,6 +623,11 @@ function install_elixir() {
git pull origin "v${version}"
fi

if [ ! "$?" = 0 ] ; then
echo "Failed to checkout Elixir version ${version}. Aborting!"
exit 1
fi

if [ "$SYSTEM" = "FreeBSD" ] ; then
MAKE=gmake
else
Expand Down