Add a CLI flag for prerelease#517
Merged
Merged
Conversation
1 task
shonfeder
approved these changes
Mar 24, 2026
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Looks good to me! (for whatever that is worth :) Thanks!)
Leonidas-from-XIV
approved these changes
Mar 24, 2026
Member
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Small improvements possible but looks good from my side.
(That said this is not surprising, this PR is the result of @Sudha247 and me pairing to add this feature)
Fixes tarides#516. Adds a flag for marking a release as aprerelease. The support for this already exists in the GitHub REST API calls. This patch exposes it to dune-release CLI. Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Deduplicate code in tests and minor clean-up Signed-off-by: Sudha Parimala <sudharg247@gmail.com>
Member
Author
|
Thanks for the reviews @shonfeder and @Leonidas-from-XIV! I've addressed your feedback and updated the PR accordingly. |
punchagan
reviewed
Mar 25, 2026
Remove the 'Closes' part as this is not being recorded in the Changelog.
This was referenced Mar 26, 2026
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Mar 26, 2026
CHANGES: ### Added - Add support for marking a release as a prerelease. (tarides/dune-release#517, @Sudha247)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #516.
Adds a flag to mark a release as an aprerelease. Support for this already exists in the GitHub REST API. This patch exposes it to
dune-releaseCLI.