fix(core): avoid mutating runtimeEnv when emptyStringAsUndefined is true#411
Open
FrancoKaddour wants to merge 1 commit into
Open
fix(core): avoid mutating runtimeEnv when emptyStringAsUndefined is true#411FrancoKaddour wants to merge 1 commit into
FrancoKaddour wants to merge 1 commit into
Conversation
`emptyStringAsUndefined` was deleting keys directly from the `runtimeEnv` object. When callers pass `process.env` (the common case), this permanently removes those keys from the global environment, breaking any code that reads them afterward. Fix by building a filtered copy instead of mutating in place.
|
@FrancoKaddour is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
emptyStringAsUndefined: trueis set, the current implementation iterates overruntimeEnvand callsdelete runtimeEnv[key]for every empty-string entry. If the caller passesprocess.env(the most common pattern), this permanently removes those keys from the globalprocess.envobject for the lifetime of the process.Reproduction
Any code that reads
process.env.DATABASE_URLaftercreateEnv(e.g. Prisma, a logger, anothercreateEnvcall) seesundefinedinstead of"". The effect is silent and hard to debug.Fix
Build a filtered copy of the env object instead of mutating it in place:
The original
runtimeEnv/process.envreference is never touched.Tests added (in
packages/core/test/smoke-zod4.test.ts):createEnv