fix(presets): guard against ReferenceError when process is not defined#410
Open
Zelys-DFKH wants to merge 5 commits into
Open
fix(presets): guard against ReferenceError when process is not defined#410Zelys-DFKH wants to merge 5 commits into
Zelys-DFKH wants to merge 5 commits into
Conversation
Module-level const evaluated at import time; the test suite reassigns process.env in a describe block, so the const captured a stale reference. A getter function evaluated at call time preserves the original behavior while remaining safe in environments where process is undefined.
|
@Zelys-DFKH is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calling any server preset (
vercel(),uploadthing(),railway(), etc.) in a browser environment without aprocesspolyfill crashes with:This happens because the preset functions call
createEnv({ runtimeEnv: process.env, ... }), andprocess.envis evaluated at call time, before any guard can fire.Fixes #407.
Fix
Each preset file (
presets-zod.ts,presets-arktype.ts,presets-valibot.ts) now defines a private getter:Each server preset passes
serverEnv()asruntimeEnv. The function is called at preset invocation time, so:process.envas beforeprocesspolyfill: returns{}— all preset env vars are optional, so validation passesviteandwxtpresets already useimport.meta.envand are unchanged.The same guard is applied to the
runtimeEnvfallback insidecreateEnv(packages/core/src/index.ts), protecting against the case where a caller omitsruntimeEnventirely in a browser context.Why not a module-level constant?
A module-level
const serverRuntimeEnv = typeof process !== "undefined" ? process.env : {}evaluates at import time. The test suite reassignsprocess.envinside adescribeblock, which runs during collection after imports complete, so a const captures a stale reference and breaks the existing"with built-in preset"test.Tests
Regression tests added to all four smoke suites (zod v3, zod v4, arktype, valibot):
This test fails on pre-fix code (accessing
process.envwhereprocessisundefinedthrowsTypeError) and passes on the fix.