Skip to content

test: add mainnet probe devtools#940

Open
piotr-iohk wants to merge 3 commits into
masterfrom
feat/mainnet-probe-devtools
Open

test: add mainnet probe devtools#940
piotr-iohk wants to merge 3 commits into
masterfrom
feat/mainnet-probe-devtools

Conversation

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Addresses https://github.com/synonymdev/bitkit-nightly/issues/10

Companion PRs:

Description

This PR:

  1. Adds a debug-only devtools command for probing a resolved Lightning invoice through ADB.
  2. Returns structured probe success/failure payloads for the mainnet probe E2E runner.
  3. Adds unit coverage for amount-based probe delegation.

Preview

N/A

QA Notes

Manual Tests

Automated Checks

  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a review, for the current state, which is a draft. Added a few nits, and, otherwise, this is a GO and LGTM 👏

I think you can handle this, feel free to continue and ask me for review / help when/if needed.

Comment thread app/src/debug/java/to/bitkit/dev/DevToolsProvider.kt Outdated
Comment thread app/src/debug/java/to/bitkit/dev/DevToolsProvider.kt
Comment thread app/src/test/java/to/bitkit/repositories/LightningRepoTest.kt Outdated
@ovitrif ovitrif added this to the 2.4.0 milestone May 12, 2026
@piotr-iohk piotr-iohk marked this pull request as ready for review May 14, 2026 14:33
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented May 14, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants