fix: stabilize send scan routing#925
Open
ovitrif wants to merge 9 commits intofeat/connection-issues-viewfrom
Open
fix: stabilize send scan routing#925ovitrif wants to merge 9 commits intofeat/connection-issues-viewfrom
ovitrif wants to merge 9 commits intofeat/connection-issues-viewfrom
Conversation
ovitrif
force-pushed
the
fix/connection-issues-view
branch
from
ac51d38 to
8c3e3d1
Compare
ovitrif
force-pushed
the
fix/connection-issues-view
branch
from
8c3e3d1 to
3851847
Compare
…-view # Conflicts: # app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Addressed the changelog fragment review note in |
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issues surfaced in #878:
Also fixes all lint issues accumulated in latest PRs (should later update build config to fail on lint errors).
Preview
before.mp4
after.mp4
QA Notes
Manual Tests
regression:Scanner → scan fixed amount LN invoice: Send Confirm or QuickPay opens directly.regression:Send → scanner/paste fixed amount LN invoice: in-sheet nav to Confirm or QuickPay.regression:Variable amount LN invoice/LNURL-pay: lands on Amount view.Automated Tests
Added new unit tests:
main scanner lightning scan opens send sheetmain scanner zero amount lightning scan opens amount sheetmain scanner lightning scan opens QuickPay when enabledwaitForUsableChannels waits for running state before treating empty channels as absent