Remove generic Stream and StreamError types#276
Merged
Conversation
kateinoigakukun
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
StreamandStreamErrorare over-generalization of generic streams, while onlyByteStreamis actually used inWasmParser, andStreamErroris always used withUInt8type parameter.Let's clean these up as unused,
WasmParseris not in the business of providing general stream APIs.StreamErroris now merged withWasmParserError, which simplifies future adoption of typed throws to unblock #273.While we're at it,
ByteStreamnow conforms to~Copyable, but ideally we'd want it to returnSpan<UInt8>and notArraySlicefrom its methods. Bumping required Swift version to 6.2 is required for that, which we're not ready to do just yet, so~Escapableconstraint is not added in this PR.