Skip to content

refactor: delete export-aws-secrets-manager, move logic to setup#3605

Draft
suzuki-shunsuke wants to merge 2 commits intomainfrom
refactor/merge-aws-secrets-by-env-name
Draft

refactor: delete export-aws-secrets-manager, move logic to setup#3605
suzuki-shunsuke wants to merge 2 commits intomainfrom
refactor/merge-aws-secrets-by-env-name

Conversation

@suzuki-shunsuke
Copy link
Copy Markdown
Owner

@suzuki-shunsuke suzuki-shunsuke commented Feb 7, 2026

Summary

  • Remove the export-aws-secrets-manager action and its router entry
  • Move AWS Secrets Manager business logic (run.ts, run.test.ts) to src/actions/setup/aws_secrets_manager.ts
  • Add awsSecretsManagerConfig to TargetConfig with env_name-based merging (jobConfig overrides group)
  • Integrate AWS Secrets Manager secret fetching directly into the setup action, unifying it with GitHub secrets into a single secrets output

Test plan

  • npm t — all 796 tests pass
  • npm run lint — clean
  • npm run fmt — clean

🤖 Generated with Claude Code

⚠️ Breaking Changes

The action export-aws-secrets-manager is removed.
Instead setup action outputs secrets.

Merge groupSecrets and jobConfigSecrets into a single flat list in
get-target-config, consistent with how GitHub secrets are already merged.
The setup action now processes this pre-merged list directly instead of
delegating to runAWSSecrets().

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke-tfaction

This comment has been minimized.

@suzuki-shunsuke suzuki-shunsuke marked this pull request as draft February 7, 2026 12:54
@suzuki-shunsuke suzuki-shunsuke force-pushed the refactor/merge-aws-secrets-by-env-name branch from 796fbe1 to 6a34c99 Compare February 8, 2026 23:18
@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/opentofu/bar-2)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/opentofu/bar)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/terragrunt/zoo-2)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/foo)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/terragrunt/zoo)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

@suzuki-shunsuke-tfaction
Copy link
Copy Markdown
Contributor

Plan Result (tests/foo-2)

CI link

Plan: 1 to add, 0 to change, 0 to destroy.
  • Create
    • null_resource.foo
Change Result (Click me)
  # null_resource.foo will be created
  + resource "null_resource" "foo" {
      + id = (known after apply)
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment