Skip to content

Fix simulator overlay height not applied when opening Preview on a ph…#7624

Open
JaneSjs wants to merge 7 commits intomasterfrom
7621-dropdowntagbox-preview-on-android-phone-in-default-landscape-orientation---no-cancel-ok-buttons-appear-on-first-start
Open

Fix simulator overlay height not applied when opening Preview on a ph…#7624
JaneSjs wants to merge 7 commits intomasterfrom
7621-dropdowntagbox-preview-on-android-phone-in-default-landscape-orientation---no-cancel-ok-buttons-appear-on-first-start

Conversation

@JaneSjs
Copy link
Copy Markdown
Contributor

@JaneSjs JaneSjs commented Apr 14, 2026

…one/tablet device

@JaneSjs JaneSjs requested a review from tsv2013 April 14, 2026 10:39
@JaneSjs JaneSjs marked this pull request as draft April 14, 2026 13:38
JaneSjs added 3 commits April 14, 2026 17:29
…ayout in simulator

- Sync detectChanges for popupOverlayHeight/device/survey so --sv-popup-overlay-height binds in the embedded view

- Defer forceProcessResponsiveness to rAF from the component after mount and model updates

- Add e2e coverage for phone preview with previewDevice and first tagbox popup

Made-with: Cursor
Copy link
Copy Markdown
Member

@tsv2013 tsv2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 'queueSurveyLayoutRefresh' function is duplicated. I believe it can be moved into simulator model class

@JaneSjs JaneSjs self-assigned this May 4, 2026
@JaneSjs JaneSjs requested a review from tsv2013 May 4, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown/Tagbox preview on android phone in default Landscape orientation - No Cancel OK buttons appear on first start

2 participants