fix: solve #3490 — cannot re-enable Show Preset Bar after toggling off#3491
Draft
github-actions[bot] wants to merge 1 commit intomainfrom
Draft
fix: solve #3490 — cannot re-enable Show Preset Bar after toggling off#3491github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
When users toggle off "Show Preset Bar" from the preset bar's cog icon, the bar disappears and the primary toggle becomes inaccessible. While a secondary toggle exists in the AddTabButton dropdown, it is not discoverable. This adds a "Show Preset Bar" switch to the General settings page (alongside similar toggles like Resource Monitor), giving users a reliable way to re-enable the preset bar. Closes #3490
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getShowPresetsBar/setShowPresetsBartRPC procedures with optimistic updates and rollback, matching the pattern of all other toggles on that page.What changed
settings-search.tsBEHAVIOR_SHOW_PRESETS_BARsetting ID and searchable entry with keywords (preset, bar, show, hide, toggle, etc.)BehaviorSettings.tsxsettings-search.test.tsTest plan
bun testonsettings-search.test.ts— all 10 tests pass (3 new + 7 existing)bun run lint:fixpasses cleanlyCloses #3490
Summary by cubic
Adds a “Show Preset Bar” toggle to Settings > General so users can re-enable the preset bar after hiding it. Fixes the lockout caused when the primary toggle disappears with the bar (closes #3490).
getShowPresetsBar/setShowPresetsBarwith optimistic updates and rollback.Written for commit b2d3072. Summary will update on new commits.