Fix Daytona sandbox reachability probe for Cloudflare quick-tunnel webapp targets (#51)#52
Merged
Conversation
|
Current version of PR was reviewed by /review-bugbot on Jul 3, 13:19 GMT+2. It flagged 0 findings. Bugbot on commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curlprobe inprepareWebappTarget()with a retrying probe (probeWebappTarget()): 5 attempts, 10 s timeout, exponential backoff (1/2/4/8 s).autobrin-flue#158reference.Context
The Daytona sandbox cannot always reach Cloudflare quick-tunnel URLs immediately. This change absorbs transient DNS propagation delays and makes the real blocker (network reachability / outbound filtering) explicit in the error output instead of blaming a closed issue.
Test plan
npx vitest run tests/daytona-bootstrap.test.tspasses.npx vitest runpasses (313 tests).npm run typecheckpasses.Limitation / follow-up
If Cloudflare is actively blocking the sandbox's outbound network, retries alone will not help. A longer-term fix may require changing the tunnel mechanism (e.g. a private Daytona network bridge or persistent tunnel). This PR is scoped to the benchpress-side robustness requested in the issue.