Skip to content

fix(postgrest): then typing #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
7ttp wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(postgrest): then typing #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/postgrest-js/src/PostgrestBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ export default abstract class PostgrestBuilder<
*
* @category Database
*/
throwOnError(): this & PostgrestBuilder<ClientOptions, Result, true> {
throwOnError(): Omit<this, 'then'> & PostgrestBuilder<ClientOptions, Result, true> {
this.shouldThrowOnError = true
return this as this & PostgrestBuilder<ClientOptions, Result, true>
return this as Omit<this, 'then'> & PostgrestBuilder<ClientOptions, Result, true>
}

/**
Expand Down
14 changes: 14 additions & 0 deletions packages/core/postgrest-js/test/index.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,20 @@ const postgrestWithOptions = new PostgrestClient<DatabaseWithOptions>(REST_URL)
error
}

{
postgrest
.from('messages')
.select('id')
.eq('id', 1)
.single()
.throwOnError()
.then(({ data, error }) => {
expectType<TypeEqual<typeof data, { id: number }>>(true)
expectType<TypeEqual<typeof error, null>>(true)
return data
})
}

// Json Accessor with custom types overrides
{
const result = await postgrest
Expand Down
Loading